Add web auth, infinite-scroll, agent admission and review fixes across agent/server/web

agent/internal/app/app_test.go

@@ -182,6 +182,81 @@ func TestEndToEndPushAndReplay(t *testing.T) {
 	}
 }
 
+func TestReloadRejectsImmutableChangesAndKeepsOldConfig(t *testing.T) {
+	oldCfg := &config.Config{
+		AgentID:  "a1",
+		Hostname: "h",
+		StateDir: "/tmp/old",
+		Server: config.ServerConfig{
+			Enabled:           boolPtr(true),
+			URL:               "http://old",
+			HeartbeatInterval: config.Duration{Duration: 10 * time.Second},
+			BatchInterval:     config.Duration{Duration: 10 * time.Second},
+		},
+		Metrics: config.MetricsConfig{Enabled: false},
+		Checks: []config.CheckConfig{{
+			ID:       "c1",
+			Command:  "true",
+			Interval: config.Duration{Duration: time.Second},
+			Timeout:  config.Duration{Duration: time.Second},
+		}},
+	}
+	newCfg := *oldCfg
+	newCfg.Server.URL = "http://new"
+	a := &App{
+		Cfg:     oldCfg,
+		AgentID: "a1",
+		Metrics: metrics.New(),
+	}
+	if err := a.Reload(&newCfg, "a1"); err == nil {
+		t.Fatal("expected immutable reload rejection")
+	}
+	if a.config().Server.URL != "http://old" {
+		t.Fatalf("old config was replaced: %+v", a.config().Server)
+	}
+}
+
+func TestReloadAcceptsLabelsAndChecks(t *testing.T) {
+	oldCfg := &config.Config{
+		AgentID:  "a1",
+		Hostname: "h",
+		StateDir: "/tmp/old",
+		Labels:   map[string]string{"env": "old"},
+		Server: config.ServerConfig{
+			Enabled:           boolPtr(true),
+			URL:               "http://server",
+			HeartbeatInterval: config.Duration{Duration: 10 * time.Second},
+			BatchInterval:     config.Duration{Duration: 10 * time.Second},
+		},
+		Metrics: config.MetricsConfig{Enabled: false},
+		Checks: []config.CheckConfig{{
+			ID:       "c1",
+			Command:  "true",
+			Interval: config.Duration{Duration: time.Second},
+			Timeout:  config.Duration{Duration: time.Second},
+		}},
+	}
+	newCfg := *oldCfg
+	newCfg.Labels = map[string]string{"env": "new"}
+	newCfg.Checks = []config.CheckConfig{{
+		ID:       "c2",
+		Command:  "true",
+		Interval: config.Duration{Duration: 2 * time.Second},
+		Timeout:  config.Duration{Duration: time.Second},
+	}}
+	a := &App{
+		Cfg:     oldCfg,
+		AgentID: "a1",
+		Metrics: metrics.New(),
+	}
+	if err := a.Reload(&newCfg, "a1"); err != nil {
+		t.Fatal(err)
+	}
+	if a.config().Labels["env"] != "new" || len(a.config().Checks) != 1 || a.config().Checks[0].ID != "c2" {
+		t.Fatalf("reload did not apply: %+v", a.config())
+	}
+}
+
 func boolPtr(v bool) *bool {
 	return &v
 }